Skip to content

feat: prefix for kv cache keys #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

feat: prefix for kv cache keys #616

merged 1 commit into from
Apr 30, 2025

Conversation

james-elicx
Copy link
Collaborator

  • Shares cache key function between inc caches.
  • Adds prefix for KV cache keys.

fixes #556

Copy link

changeset-bot bot commented Apr 29, 2025

🦋 Changeset detected

Latest commit: fb6e348

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Apr 29, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@616

commit: fb6e348

@james-elicx james-elicx marked this pull request as ready for review April 29, 2025 21:16
@james-elicx james-elicx requested a review from vicb April 29, 2025 21:16
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James!

I added one question about how the prefix is retrieved when populating the cache.

The PR otherwise LGTM

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@james-elicx james-elicx merged commit f129602 into main Apr 30, 2025
7 checks passed
@james-elicx james-elicx deleted the james/kv-dir branch April 30, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support directory for KV inc cache
2 participants