Fix node timers #619
Merged
Fix node timers #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6b466c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
Thanks for the fix @conico974 FYI this was discussed internally and we decided that mixing APIs would not be a problem (documented here). I'll raise the issue again internally. One possible fix would be to update unenv (with the caveat that external modules would not be polyfilled). For now I'm +1 for this PR. |
vicb
reviewed
Apr 30, 2025
vicb
reviewed
May 2, 2025
vicb
approved these changes
May 2, 2025
vicb
reviewed
May 2, 2025
Co-authored-by: Victor Berchet <victor@suumit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is expected that the global timers (i.e.
setInterval,setTimeout) in Node returns aNodejs.Timeoutinstead of a number. On cloudflare workers they return a number.This can cause some unexpected crash like in #587, where sentry tries to call
unref()on the created interval.This PR fix #587
The only downsides to doing that is that in the middleware we'll have access to the Node version as well, but i don't think this is too big of an issue