fix cache population hanging #648
Conversation
🦋 Changeset detectedLatest commit: 12b30cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
| const proxy = await getPlatformProxy<CloudflareEnv>(populateCacheOptions); | ||
| const prefix = proxy.env[R2_CACHE_PREFIX_ENV_NAME]; // Set the cache type to R2 for the current environment | ||
| await proxy.dispose(); |
There was a problem hiding this comment.
2 nits:
- Maybe extract this into
async getEnvFromPlatformProxy()? - Only call it after line 109 (i.e. skip if not needed)
There was a problem hiding this comment.
Maybe extract this into async getEnvFromPlatformProxy()
I was thinking actually that we could use the proxy bindings when target is local. I just tested that and it's like a 60 times speed up WDYT ?
Probably in another PR though
There was a problem hiding this comment.
We can create an issue for now.
I think implementing batch population in wrangler would be better as it could benefit other projects.
I knew it was probably something related to wrangler process, so it was either the wrangler update or the proxy. |
Should fix #647