Skip to content

chore: correct typo in redirects-rewrites.md #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 14, 2022
Merged

chore: correct typo in redirects-rewrites.md #1170

merged 6 commits into from
Feb 14, 2022

Conversation

kylegach
Copy link

Summary

I think there is a minor typo in the "When to use Next.js redirects or rewrites" section, which could result in some confusion.

@kylegach
Update redirects-rewrites.md
663203f 
Correct what seemed to be a minor typo
@netlify
Copy link

netlify bot commented Jan 27, 2022 •
edited
Loading

✔️ Deploy Preview for netlify-plugin-nextjs-demo ready!

🔨 Explore the source changes: 197cb6f

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/620a7d496735a80007dc5dec

😎 Browse the preview: https://deploy-preview-1170--netlify-plugin-nextjs-demo.netlify.app

@netlify
Copy link

netlify bot commented Jan 27, 2022 •
edited
Loading

👷 Deploy request for netlify-plugin-nextjs-nx-monorepo-demo pending review.
Visit the deploys page to approve it

🔨 Explore the source changes: 197cb6f

@netlify
Copy link

netlify bot commented Jan 27, 2022 •
edited
Loading

👷 Deploy request for netlify-plugin-nextjs-export-demo pending review.
Visit the deploys page to approve it

🔨 Explore the source changes: 197cb6f

@netlify
Copy link

netlify bot commented Jan 27, 2022 •
edited
Loading

👷 Deploy request for netlify-plugin-nextjs-static-root-demo pending review.
Visit the deploys page to approve it

🔨 Explore the source changes: 197cb6f

@kylegach
Copy link
Author

The PR template instructed me to assign myself and a specific reviewer, but I cannot. I also cannot label this PR, as the check demands.

Sorry about not following conventional-commit. Happy to re-submit with a proper message, if necessary. Thanks!

@ascorbic
Copy link
Contributor

Thanks! No worries about the other parts: I'll deal with it.

@ascorbic ascorbic changed the title Correct typo in redirects-rewrites.md chore: correct typo in redirects-rewrites.md Jan 27, 2022
@ascorbic ascorbic added automerge type: chore work needed to keep the product and development running smoothly labels Jan 27, 2022
@kodiakhq kodiakhq bot merged commit c2166d6 into opennextjs:main Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic ascorbic approved these changes

Assignees
No one assigned
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylegach @ascorbic