test: adjust assertions for /_not-found being possibly added to prerender manifest #3043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
cc027d0 to
26a1fc4
Compare
pieh
commented
Aug 12, 2025
Comment on lines
+33
to
+40
| export function shouldHaveAppRouterNotFoundInPrerenderManifest() { | ||
| // https://github.com/vercel/next.js/pull/82199 | ||
|
|
||
| // The canary versions are out of band, as there stable/latest patch versions higher than base of canary versions | ||
| // and change was not backported to stable versions | ||
| return nextVersionSatisfies('>=15.4.2-canary.33') && isNextCanary() | ||
| } | ||
|
|
There was a problem hiding this comment.
This is really annoying and frankly bad check that will likely need to be adjusted once that change is released in stable, but to me it feels better than doing some kind of filtering in tests themselves. At least it will be somewhat explicit of what full list of generated blobs are (...depending on next version :/ )
mrstork
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To account for vercel/next.js#82199
Documentation
Tests
You can test this change yourself like so:
Relevant links (GitHub issues, etc.) or a picture of cute animal