fix: force serverless target #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c67715 to
af78226
Compare
lindsaylevine
approved these changes
Jun 11, 2021
|
|
||
| // Creating a config file, because otherwise Next won't reload the config and pick up the new target | ||
|
|
||
| if (!(await findUp('next.config.js'))) { |
There was a problem hiding this comment.
fyi this is part of the monorepo problem. just an fyi we can address later
helpers/verifyBuildTarget.js
Outdated
| // Creating a config file, because otherwise Next won't reload the config and pick up the new target | ||
|
|
||
| if (!(await findUp('next.config.js'))) { | ||
| await writeFile(path.resolve('next.config.js'), `module.exports = {}`) |
There was a problem hiding this comment.
at this should we maybe just add the target prop in here as a backup? not necessary ofc
There was a problem hiding this comment.
yeah, I'm unsure what's best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt at #343, forcing the target to "serverless". The previous PR had to be reverted, because it didn't work when there was no next.config.js file. The target stayed as "server", meaning no serverless files were generated. This is because for some reason Next.js didn't change the target unless the config file at least exists. We work around this by creating the file if it doesn't exist, but without any config in it.