Skip to content

fix: disable png palette #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 13, 2021
Merged

fix: disable png palette #525

merged 4 commits into from
Jul 13, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Jul 13, 2021

Disables png and jpeg optimisation temporarily because it's very slow. This means the output images are larger, but it was unacceptably slow to process. We'll address this with the new image function. We also disable the redirect when requesting images larger than the source. Instead we just disable upsizing. Redirecting meant we'd need to request the source image twice, which was expensive.

Fixes #507

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Jul 13, 2021
@ascorbic ascorbic requested a review from lindsaylevine July 13, 2021 13:29
@ascorbic ascorbic enabled auto-merge (squash) July 13, 2021 14:28
@ascorbic ascorbic merged commit e0b4bf7 into main Jul 13, 2021
@ascorbic ascorbic deleted the fix/no-optim branch July 13, 2021 14:40
serhalp pushed a commit that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requests for Images Take Seconds to Complete
2 participants