fix: remove swc binaries #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindsaylevine
approved these changes
Oct 8, 2021
043fb79 to
f066c83
Compare
|
folks, can I get notified when this is live and users get it automatically in their builds? I'd like to keep an extra eye as soon as we can see its effects |
|
@ricbartm Will do. I'll get the PR open tomorrow AM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next 11.1.0 added a dependency on swc that meant a >30MB binary was being bundled inside every function. The latest version of zip-it-and-ship-it allows you to exclude node modules from the bundle. This fix approximately halves the size of the bundle on the demo site.