feat: add experimental support for TTL #833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1d4562 to
a36e76e
Compare
a36e76e to
8576607
Compare
13ebc04 to
26df099
Compare
26df099 to
8302eca
Compare
1a30536 to
8e441e3
Compare
8e441e3 to
fd48686
Compare
Release-as: 4.0.0-beta.12
tiffafoo
reviewed
Nov 25, 2021
src/templates/handlerUtils.ts
Outdated
| const multiValueHeaders: Record<string, Array<string>> = {} | ||
| for (const key of Object.keys(headers)) { | ||
| if (Array.isArray(headers[key])) { | ||
| multiValueHeaders[key] = headers[key] as Array<string> |
There was a problem hiding this comment.
You could do the following instead so you don't need to coerce
const header = headers[key];
if (Array.isArray(header)) {
multiValueHeaders[key] = header
} else {
multiValueHeaders[key] = [header]
}e92b152 to
e6bbabe
Compare
tiffafoo
reviewed
Nov 25, 2021
| @@ -219,6 +219,57 @@ exports.moveStaticPages = async ({ netlifyConfig, target, i18n }) => { | |||
| } | |||
| } | |||
|
|
|||
| const patchFile = async ({ file, from, to }) => { | |||
tiffafoo
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds experimental support for ttl in pages with revalidate set. Parses the cache-control header returned by Next and extracts the
s-maxagevalue, which it then uses in the ttl response. This isnlt enabled by default, but requires an env var flag.As part of the build process we need to patch the
next-server.jsfile, because we need to disable caching for ISR pages and currently this is only supported forminimalMode. We do this by adding another env var to the line where it checks for all the conditions for disabling the SSG cache.Test plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal