feat: add support for Next env vars #842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release-As: 4.0.0-beta.12
aca75c6 to
d7d809e
Compare
tiffafoo
reviewed
Nov 29, 2021
| @@ -26,6 +26,8 @@ | |||
| "publish:test": "npm test", | |||
| "test": "run-s build build:demo test:jest", | |||
| "test:jest": "jest", | |||
| "test:jest:update": "jest --updateSnapshot", | |||
| "test:update": "run-s build build:demo test:jest:update", | |||
There was a problem hiding this comment.
[sand] we might want to use actual objects, this makes it too easy to run this and ignore snapshots and captures implementation details. It might be a huge object but at least the update will be more deliberate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for Next env var files
Test plan
Check the following pages for the string "Hello Production"
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes #823