Skip to content

feat: enable TTL for all sites #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2021
Merged

feat: enable TTL for all sites #916

merged 2 commits into from
Dec 7, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Dec 7, 2021

Summary

Unflags TTL support for revalidate. Adds warning for short revalidate values.

Test plan

  1. The env var has now been remopved from the demo site, so it can be checked on the deploy preview of the demo
  2. Check the demo logs for the short revalidate warning

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

image

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@netlify
Copy link

netlify bot commented Dec 7, 2021

✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

🔨 Explore the source changes: e81adf6

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/61af2f58aca9070007476c38

😎 Browse the preview: https://deploy-preview-916--netlify-plugin-nextjs-static-root-demo.netlify.app

@ascorbic ascorbic requested a review from tiffafoo December 7, 2021 09:46
@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Dec 7, 2021
@netlify
Copy link

netlify bot commented Dec 7, 2021

✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

🔨 Explore the source changes: e81adf6

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61af2f58a2a3fe0007eaca2b

😎 Browse the preview: https://deploy-preview-916--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app/

Copy link

@tiffafoo tiffafoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@kodiakhq kodiakhq bot merged commit 152cf03 into main Dec 7, 2021
@kodiakhq kodiakhq bot deleted the mk/unflag-ttl branch December 7, 2021 10:07
@ascorbic ascorbic self-assigned this Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants