fix: bypass preview for static files #918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release-As: 4.0.0-rc.1
|
✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready! 🔨 Explore the source changes: 0d7c905 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/61af50ae1377350007c1e5f2 😎 Browse the preview: https://deploy-preview-918--netlify-plugin-nextjs-static-root-demo.netlify.app |
|
✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready! 🔨 Explore the source changes: 0d7c905 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61af50ad6db60100077ab551 😎 Browse the preview: https://deploy-preview-918--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app/ |
tiffafoo
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently we have a forced redirect to the handler funciton if preview mode is on, as it needs to bypass ODBs and SSG pages. However this means it also forces a rewrite for files from
public, causing broken images and other static files. This PR adds no-op rewrites for any files from that directory, ensuring that they don't match the force redirect and are instead served from the CDN.Test plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Closes #753
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.