Refactor ensureJob away from named return values #1071
Conversation
Signed-off-by: Anik Bhattacharjee <anbhatta@gmail.com> Upstream-repository: operator-registry Upstream-commit: 919aefdce3f4d6b77c3872df249815d20749db94
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: d7aaeb11ab80f862fc9c70dfb7865158bb67e28c
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b6291f2 to
b9851f4
Compare
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
b9851f4 to
b68c1fe
Compare
|
/retest |
| err = c.client.BatchV1().Jobs(job.GetNamespace()).Delete(context.TODO(), job.GetName(), metav1.DeleteOptions{}) | ||
| job = nil | ||
| return | ||
| return nil, err |
There was a problem hiding this comment.
The job = nil line seems leftover from the named return code?
| err = c.client.BatchV1().Jobs(job.GetNamespace()).Delete(context.TODO(), job.GetName(), metav1.DeleteOptions{}) | |
| job = nil | |
| return | |
| return nil, err | |
| return nil, c.client.BatchV1().Jobs(job.GetNamespace()).Delete(context.TODO(), job.GetName(), metav1.DeleteOptions{}); |
|
@perdasilva: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.