Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements from issue 1808 #23

Merged
merged 5 commits into from
Nov 21, 2022
Merged

Conversation

tskir
Copy link
Contributor

@tskir tskir commented Nov 17, 2022

  • Add --version flag to print version and exit
  • Sort URI_MAPPING and add entry for CHEBI
  • Expand documentation on local installation and testing
  • Update tests to reflect changes in EFO
  • Bump VERSION to v1.0.3

Closes opentargets/issues#1808.

@tskir tskir requested a review from DSuveges November 17, 2022 14:35
@tskir
Copy link
Contributor Author

tskir commented Nov 17, 2022

Some tests have started failing because the example terms which they relied upon have changed in EFO, most notably due to mass migration to MONDO terms. All tests have now been updated.

Also expanded documentation to mention local installation and testing

@tskir tskir requested a review from ireneisdoomed November 18, 2022 11:00
Copy link
Contributor

@DSuveges DSuveges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks nice and make sense.

@DSuveges DSuveges merged commit e78ece6 into master Nov 21, 2022
@tskir tskir deleted the 1808-tskir-minor-improvements branch September 20, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate ontoma's lost mappings for future iterations
2 participants