fix: Fix a universal OpenAI API #252

lu-yg · 2025-08-06T10:48:19Z

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

New Features
- Added support for specifying tools in chat requests, enhancing interaction capabilities.

…va into feat/docker

coderabbitai · 2025-08-06T10:48:26Z

Walkthrough

The AI chat service implementation was updated to include a new tools field in the chat request DTO and to add this field into the request body construction. The URI construction in chatCompletion was also refactored to assign the base URL to a local variable before building the URI.

Changes

Cohort / File(s)	Change Summary
AI Chat Service Implementation Updates `base/src/main/java/com/tinyengine/it/service/app/impl/v1/AiChatV1ServiceImpl.java`	Refactored URI construction by assigning the chosen base URL to a local variable. Added `"tools"` field to the request body from `request.getTools()`.
Chat Request DTO Enhancement `base/src/main/java/com/tinyengine/it/model/dto/ChatRequest.java`	Added new field `tools` as a list of maps (String to Object) to represent additional tool data in chat requests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

A rabbit’s new tool hops into the chat,
With maps and lists, imagine that!
The base URL now neatly stored,
Requests enriched and code restored.
🐇🔧✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ce518c and 8331a15.

📒 Files selected for processing (2)

base/src/main/java/com/tinyengine/it/model/dto/ChatRequest.java (2 hunks)
base/src/main/java/com/tinyengine/it/service/app/impl/v1/AiChatV1ServiceImpl.java (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

base/src/main/java/com/tinyengine/it/service/app/impl/v1/AiChatV1ServiceImpl.java

🔇 Additional comments (2)

base/src/main/java/com/tinyengine/it/model/dto/ChatRequest.java (2)

18-18: LGTM: Import addition supports new functionality.

The import for java.util.Map is correctly added to support the new tools field.

31-31: LGTM: Tools field correctly implements OpenAI API specification.

The tools field addition aligns well with the OpenAI API specification for function calling and tools. The type List<Map<String, Object>> provides the necessary flexibility for different tool definitions while maintaining collection-level type safety.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 2

🔭 Outside diff range comments (1)

base/src/main/java/com/tinyengine/it/service/app/impl/v1/AiChatV1ServiceImpl.java (1)
46-50: Avoid manual instantiation of OpenAIConfig; prefer Spring injection

new OpenAIConfig() bypasses Spring’s configuration binding, so any application.yml overrides will not reach this instance. Inject the bean instead:
- private final OpenAIConfig config = new OpenAIConfig();
+ private final OpenAIConfig config;
+
+ public AiChatV1ServiceImpl(OpenAIConfig config) {
+     this.config = config;
+ }
This ensures externalized configuration and avoids duplicated objects.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0fd760c and 9c395aa.

📒 Files selected for processing (2)

base/src/main/java/com/tinyengine/it/config/OpenAIConfig.java (1 hunks)
base/src/main/java/com/tinyengine/it/service/app/impl/v1/AiChatV1ServiceImpl.java (1 hunks)

base/src/main/java/com/tinyengine/it/config/OpenAIConfig.java

base/src/main/java/com/tinyengine/it/service/app/impl/v1/AiChatV1ServiceImpl.java

lu-yg and others added 19 commits July 13, 2025 19:28

feat: add docker-compose file

262db02

feat: add maven settings.xml

a6bab59

feat: add docker deploy

5ed6d4e

feat: add dockerfile

7253d72

add docker deploy

8adea2a

add docker deploy

3d418bf

feat: add docker deploy

987512d

fix: fix application-alpha.yml

a9ad907

fix: Fix nginx.conf

899816f

fix: Fix init_data_for_test_v1.0.0.sql

2b9768d

fix: fix init_data_for_test_v1.0.0.sql

f190b6f

fix: fix init_data_for_test_v1.0.0.sql

797ba7a

feat: Add a universal OpenAI API

7e668bf

Merge branch 'opentiny:develop' into feat/docker

dac0490

Merge branch 'feat/docker' of github.com:lu-yg/tiny-engine-backend-ja…

61b73ee

…va into feat/docker

feat: Add a universal OpenAI API

75d535e

feat: Add a universal OpenAI API

55af856

fix: Fix a universal OpenAI API

eb55ed6

fix: Fix a universal OpenAI API

9c395aa

coderabbitai bot reviewed Aug 6, 2025

View reviewed changes

base/src/main/java/com/tinyengine/it/config/OpenAIConfig.java Outdated Show resolved Hide resolved

base/src/main/java/com/tinyengine/it/service/app/impl/v1/AiChatV1ServiceImpl.java Outdated Show resolved Hide resolved

fix: Fix a universal OpenAI API

003e498

hexqi reviewed Aug 7, 2025

View reviewed changes

base/src/main/java/com/tinyengine/it/service/app/impl/v1/AiChatV1ServiceImpl.java Outdated Show resolved Hide resolved

lu-yg added 2 commits August 6, 2025 18:28

fix: Fix a universal OpenAI API

7ce518c

fix: Fix a universal OpenAI API

8331a15

hexqi approved these changes Aug 7, 2025

View reviewed changes

hexqi merged commit 869f19a into opentiny:develop Aug 7, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Fix a universal OpenAI API #252

fix: Fix a universal OpenAI API #252

Uh oh!

lu-yg commented Aug 6, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Aug 6, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix: Fix a universal OpenAI API #252

fix: Fix a universal OpenAI API #252

Uh oh!

Conversation

lu-yg commented Aug 6, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR

PR Checklist

PR Type

Background and solution

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lu-yg commented Aug 6, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 6, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)