fix(alert): move close icon to center #2856

shenjunjian · 2025-02-05T08:15:37Z

PR

修复Alert组件的关闭按钮偏下的问题

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

Style
- Enhanced the visual presentation of the alert component by refining the styling applied to the alert icon, ensuring that the close icon maintains a distinct appearance.
- Retained design decisions regarding border styling for a consistent look.

coderabbitai · 2025-02-05T08:15:46Z

Walkthrough

This pull request refines the styling of the alert component by updating the CSS selector for the alert icon. The selector now excludes elements with the "close" class by applying the :not(.@{alert-prefix-cls}__close) pseudo-class. The update maintains a comment regarding the intentional omission of border-related CSS variables, with no changes made to the exported or public entities.

Changes

File(s)	Change Summary
packages/theme/.../alert/index.less	Updated alert icon selector from `.@{alert-prefix-cls}__icon` to `.@{alert-prefix-cls}__icon:not(.@{alert-prefix-cls}__close)`; retained border comment.

Possibly related PRs

fix(alert): [alert] updata alert xdesign #2083: Involves design updates for the alert component affecting its styling.
feat(alert): [alert] Adapting to the SMB theme #2169: Contains modifications to CSS properties in the same index.less file, directly related to this change.

Suggested labels

bug

Suggested reviewers

zzcr

Poem

I'm a bunny, hopping with delight,
CSS refined for alert icons so bright.
No more confusion between close and show,
Just clean styling wherever you go.
A little nibble of code, a joyful leap—
Celebrating updates that make our project neat!

Tip

🌐 Web search-backed reviews and chat

We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
You can disable this feature by setting web_search: false in the knowledge_base settings.
Please share any feedback in the Discord discussion.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

petercat-assistant · 2025-02-05T08:15:53Z

Walkthrough

此PR修复了Alert组件中关闭按钮偏下的问题，通过调整样式使关闭按钮居中。主要修改了样式文件以确保关闭按钮不受其他图标样式的影响。

Changes

文件	摘要
packages/theme/src/alert/index.less	修改了样式选择器，确保关闭按钮不受其他图标样式的影响。

petercat-assistant · 2025-02-05T08:15:56Z

packages/theme/src/alert/index.less

@@ -32,7 +32,7 @@
  }

  /** alert-icon 场景 */
-  .@{alert-prefix-cls}__icon {
+  .@{alert-prefix-cls}__icon:not(.@{alert-prefix-cls}__close) {


确保选择器的更改不会影响其他图标的样式。此更改将关闭按钮从其他图标样式中排除，确保其居中显示。

Issues-translate-bot · 2025-02-05T08:16:05Z

Bot detected the issue body's language is not English, translate it automatically.

Walkthrough

This PR fixes the problem of down-down button in the Alert component, centering the close button by adjusting the style. The style file is mainly modified to ensure that the close button is not affected by other icon styles.

Changes

| File | Summary |
| --- | --- | |
| Packages/Theme/SRC/ALERT/Index.less | Modified the style selector to ensure that the closing button is not affected by other icon styles. | |

github-actions · 2025-02-05T08:16:12Z

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/theme/src/alert/index.less (1)
35-40: CSS Selector Refinement for Alert Icon

The updated selector
.@{alert-prefix-cls}__icon:not(.@{alert-prefix-cls}__close)
ensures that the styling (including the margin-top: 2px;) is applied only to the alert icon and not to the close icon. This change appropriately targets the non-close icons and should correct the misalignment issue of the close button by allowing its dedicated styling (defined later) to take full effect.

To further enhance maintainability, consider verifying that the individually defined properties for the close icon (from lines 68 onward) are sufficient for centering it in all alert contexts, especially when combined with modifiers like .is-center.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 90e3c9b and 9935904.

📒 Files selected for processing (1)

packages/theme/src/alert/index.less (1 hunks)

fix(alert): move close icon to center

9935904

github-actions bot added the bug Something isn't working label Feb 5, 2025

petercat-assistant bot reviewed Feb 5, 2025

View reviewed changes

coderabbitai bot reviewed Feb 5, 2025

View reviewed changes

zzcr approved these changes Feb 5, 2025

View reviewed changes

zzcr merged commit eca3888 into opentiny:dev Feb 5, 2025
7 checks passed

shenjunjian deleted the dev-alert-close-position branch March 10, 2025 11:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(alert): move close icon to center #2856

fix(alert): move close icon to center #2856

Uh oh!

shenjunjian commented Feb 5, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 5, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

petercat-assistant bot commented Feb 5, 2025

Uh oh!

petercat-assistant bot Feb 5, 2025

Uh oh!

Issues-translate-bot commented Feb 5, 2025

Uh oh!

github-actions bot commented Feb 5, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

fix(alert): move close icon to center #2856

fix(alert): move close icon to center #2856

Uh oh!

Conversation

shenjunjian commented Feb 5, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

petercat-assistant bot commented Feb 5, 2025

Walkthrough

Changes

Uh oh!

petercat-assistant bot Feb 5, 2025

Choose a reason for hiding this comment

Uh oh!

Issues-translate-bot commented Feb 5, 2025

Walkthrough

Changes

Uh oh!

github-actions bot commented Feb 5, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shenjunjian commented Feb 5, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 5, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)