fix(dialog-select): [dialog-select] fixed an issue where grid data could not be loaded when initially visible was set to true #2862

shenjunjian · 2025-02-07T02:34:45Z

…d when initially visible was set to true

PR

修复问题单： dialog-select组件，初始就将visible设置为true时，表格数据不加载的问题

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

Refactor
- Improved the initialization of grid data in dialogs so that updates now occur seamlessly after the interface renders. This ensures a more consistent and reliable display of data when dialogs open.

…d when initially visible was set to true

coderabbitai · 2025-02-07T02:34:51Z

Walkthrough

This change modifies the watch function in the dialog-select component. The call to api.queryGridData() is now wrapped in a nextTick callback to ensure the DOM is updated before execution. Additionally, the watcher is configured with { immediate: true } so that it triggers right away upon component initialization.

Changes

File	Change Summary
packages/renderless/.../vue.ts	Updated the watch function to wrap api.queryGridData() in nextTick and added an options object ({ immediate: true }) to trigger the watcher immediately.

Sequence Diagram(s)

sequenceDiagram
    participant C as Component
    participant N as nextTick
    participant A as API

    C->>C: Detect change on props.visible
    alt When visible is true and store not initialized
        C->>N: Call nextTick(callback)
        N->>C: After DOM update
        C->>A: Call api.queryGridData()
    end

Possibly related PRs

fix(dialog-select): fixed an issue where grid data could not be loaded when initially visible was set to true #2835: Adjusts the same watch function in dialog-select/vue.ts to improve the timing of api.queryGridData() execution.

Suggested labels

bug

Suggested reviewers

zzcr

Poem

Hi! I'm a code rabbit, hopping through the night,
I see the DOM updates glow with a new, timely light.
NextTick keeps us jumping in perfect sync,
Querying data only when it's time to think.
Hoppy code, hoppy life—let’s celebrate this delight!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b3e76e and ad905ff.

📒 Files selected for processing (1)

packages/renderless/src/dialog-select/vue.ts (1 hunks)

🔇 Additional comments (1)

packages/renderless/src/dialog-select/vue.ts (1)

130-140: LGTM! The changes effectively fix the initial loading issue.

The implementation properly addresses the reported issue by:

Using nextTick to ensure proper timing of the data query

Adding immediate: true to handle the initial visibility state correctly

This is a robust solution that follows Vue.js best practices for handling component initialization and reactivity.

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-02-07T02:35:26Z

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

fix(dialog-select): fixed an issue where grid data could not be loade…

ad905ff

…d when initially visible was set to true

github-actions bot added the bug Something isn't working label Feb 7, 2025

shenjunjian changed the title ~~fix(dialog-select): fixed an issue where grid data could not be loade…~~ fix(dialog-select): [dialog-select] fixed an issue where grid data could not be loaded when initially visible was set to true Feb 7, 2025

zzcr approved these changes Feb 7, 2025

View reviewed changes

zzcr merged commit ffbebe4 into opentiny:dev Feb 7, 2025
34 of 42 checks passed

shenjunjian deleted the fix-dialog-select-visible-nexttick branch March 10, 2025 11:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(dialog-select): [dialog-select] fixed an issue where grid data could not be loaded when initially visible was set to true #2862

fix(dialog-select): [dialog-select] fixed an issue where grid data could not be loaded when initially visible was set to true #2862

Uh oh!

shenjunjian commented Feb 7, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 7, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Feb 7, 2025

Uh oh!

Uh oh!

Uh oh!

fix(dialog-select): [dialog-select] fixed an issue where grid data could not be loaded when initially visible was set to true #2862

fix(dialog-select): [dialog-select] fixed an issue where grid data could not be loaded when initially visible was set to true #2862

Uh oh!

Conversation

shenjunjian commented Feb 7, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Feb 7, 2025

Uh oh!

Uh oh!

Uh oh!

shenjunjian commented Feb 7, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)