fix(tabs): [tabs] Fixed the bug where the use of separators in tabs resulted in misaligned buttons at both ends and separators not being centered #2912

chenxi-20 · 2025-02-18T02:49:41Z

PR

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

Style
- Enhanced tab component layout and visual alignment.
- Updated the navigation area's display settings for improved arrangement of elements.
- Adjusted the separator positioning to achieve a more balanced header appearance.

coderabbitai · 2025-02-18T02:49:48Z

Walkthrough

This pull request updates the styling of the tab components in the theme package. The changes involve enhancing the layout of the navigation wrapper by applying flexbox properties and center alignment to the &__nav-wrap class. Additionally, a previously set top: 2px on the &__item-separator has been removed. No changes were made to exported or public entities.

Changes

File	Change Summary
packages/.../tabs/index.less	Added `display: flex;` and `align-items: center;` to the `&__nav-wrap` class; removed `top: 2px` from `&__item-separator`.

Possibly related PRs

fix(tabs): [tabs, anchor] Fix tabs view issue #1925: Addresses styling adjustments for tab components and separator height modifications.
fix(tabs): [tabs] Optimize the tabs document #2497: Involves similar modifications in the index.less file targeting tab component styling.
fix(tabs): [tabs] Fixed the floating issue of the close button on the tab page and the style issue of the close button under the buttoncard. #2425: Focuses on updating the styling of item separators within the tab component.

Suggested reviewers

zzcr

Poem

Hop, hop, I code with delight,
Flexing styles that shine so bright.
Tabs align in a graceful parade,
Separators now gently fade.
A bunny cheers on this style upgrade!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b2215cb and 42ba056.

📒 Files selected for processing (1)

packages/theme/src/tabs/index.less (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: PR E2E Test (pnpm test:e2e3)

🔇 Additional comments (1)

packages/theme/src/tabs/index.less (1)

89-90: Enhance Navigation Layout with Flexbox

Adding display: flex; and align-items: center; to the &__nav-wrap class directly addresses the misalignment issue described in the PR. This change will ensure that the navigation container’s child elements (including tab buttons and any separators) are vertically centered. Please verify that these flex properties work consistently across all supported browsers; if legacy browser support (e.g., Internet Explorer) is still required, you may need to consider appropriate fallbacks.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

petercat-assistant · 2025-02-18T02:49:54Z

Walkthrough

This pull request addresses a bug in the tabs component where the use of separators caused misalignment of buttons at both ends and prevented separators from being centered. The changes involve CSS adjustments to ensure proper alignment and centering.

Changes

File	Summary
packages/theme/src/tabs/index.less	Added flexbox properties to `&__nav-wrap` for alignment and removed top positioning from separators to fix alignment issues.

petercat-assistant · 2025-02-18T02:49:56Z

packages/theme/src/tabs/index.less

@@ -86,6 +86,8 @@

      // 最外层页签栏盒子
      &__nav-wrap {
+        display: flex;
+        align-items: center;


The addition of display: flex; and align-items: center; to &__nav-wrap ensures that the tabs are properly aligned vertically, which should resolve the misalignment issue described in the PR.

fix(tabs): [tabs] 修复页签使用分隔符导致两端按钮无法对齐以及分隔符未居中的bug

42ba056

chenxi-20 added the bug Something isn't working label Feb 18, 2025

petercat-assistant bot reviewed Feb 18, 2025

View reviewed changes

zzcr approved these changes Feb 18, 2025

View reviewed changes

zzcr merged commit 352b7dd into dev Feb 18, 2025
10 of 11 checks passed

coderabbitai bot mentioned this pull request Apr 2, 2025

fix:[steps,date-picker,tabs,search]Dark Theme Adaptation #3231

Merged

13 tasks

kagol deleted the fix/tabs-ask-20250217 branch April 14, 2025 12:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(tabs): [tabs] Fixed the bug where the use of separators in tabs resulted in misaligned buttons at both ends and separators not being centered #2912

fix(tabs): [tabs] Fixed the bug where the use of separators in tabs resulted in misaligned buttons at both ends and separators not being centered #2912

Uh oh!

chenxi-20 commented Feb 18, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 18, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

petercat-assistant bot commented Feb 18, 2025

Uh oh!

petercat-assistant bot Feb 18, 2025

Uh oh!

Uh oh!

Uh oh!

fix(tabs): [tabs] Fixed the bug where the use of separators in tabs resulted in misaligned buttons at both ends and separators not being centered #2912

fix(tabs): [tabs] Fixed the bug where the use of separators in tabs resulted in misaligned buttons at both ends and separators not being centered #2912

Uh oh!

Conversation

chenxi-20 commented Feb 18, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

petercat-assistant bot commented Feb 18, 2025

Walkthrough

Changes

Uh oh!

petercat-assistant bot Feb 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chenxi-20 commented Feb 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 18, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)