fix(button): [select] add button's cssvar and fix select reference slot's problem #2941

shenjunjian · 2025-02-21T02:38:10Z

PR

补充button的图标色的组件变量

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

Style
- Updated button icon styling to use a dedicated color property for consistent appearance.
- Introduced a new variable for managing icon colors in buttons.
Refactor
- Refined focus management in selection components to better handle scenarios with additional content, preventing unnecessary focus state changes.

coderabbitai · 2025-02-21T02:38:18Z

Walkthrough

The pull request updates styling and control flow in two separate areas. In the button component, CSS variable references are updated to consistently derive icon colors from a new button-specific variable. In the renderless select component, the setSoftFocus function is modified to check for the presence of a reference slot, exiting early if found, and removing the reset of the soft focus state.

Changes

File(s)	Change Summary
`packages/theme/src/button/index.less` and `packages/theme/src/button/vars.less`	Updated icon colors in button styles by replacing `var(--tv-color-icon)` with `var(--tv-Button-icon-color)` and added a new variable definition in `vars.less`.
`packages/renderless/src/select/index.ts`	Modified `setSoftFocus` to return early when `vm.$slots.reference` exists, and removed the line that resets `state.softFocus` to false.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant setSoftFocus
    Caller->>setSoftFocus: call setSoftFocus()
    alt vm.$slots.reference exists
        setSoftFocus->>Caller: return early (skip setting softFocus)
    else
        setSoftFocus->>setSoftFocus: set state.softFocus = true
        setSoftFocus->>Caller: continue with focus handling
    end

Possibly related PRs

feat(theme): modify variable names and add reset styles #2185: Updates CSS variable references affecting button icon colors.
feat(theme): [button] add dark themes, modify other theme variables and component level variables #2898: Introduces a new CSS variable (--tv-Button-icon-color) for button styling.
feat(button): [button] Adapting to the SMB theme #1937: Adjusts the addition and modification of CSS variables for button icon colors.

Suggested labels

enhancement

Suggested reviewers

zzcr

Poem

I'm a little bunny hopping through the code,
With buttons now dressed in a brand new mode.
Icon colors gleam as my whiskers twitch,
Soft focus flows without a hitch.
🐇 Celebrate the changes, let’s hit the road!

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/renderless/src/select/index.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eca55d5 and 3817d8d.

📒 Files selected for processing (1)

packages/renderless/src/select/index.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/renderless/src/select/index.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-02-21T02:38:42Z

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

…lecting items in the select component when it is in multiple and filterable mode

fix(button): add button's cssvar

dcfb23d

github-actions bot added the bug Something isn't working label Feb 21, 2025

fix(select): fix the issue where the focus event is triggered when se…

eca55d5

…lecting items in the select component when it is in multiple and filterable mode

shenjunjian changed the title ~~fix(button): add button's cssvar~~ fix(button): [select] add button's cssvar and fix select reference slot's problem Feb 21, 2025

fix(select): fix

3817d8d

zzcr approved these changes Feb 21, 2025

View reviewed changes

zzcr merged commit a78c1c4 into opentiny:dev Feb 21, 2025
8 of 10 checks passed

shenjunjian deleted the fix-button-add-vars branch March 10, 2025 11:35

coderabbitai bot mentioned this pull request Mar 27, 2025

fix(button): [button] Adapt to dark themes #3208

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(button): [select] add button's cssvar and fix select reference slot's problem #2941

fix(button): [select] add button's cssvar and fix select reference slot's problem #2941

Uh oh!

shenjunjian commented Feb 21, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 21, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Feb 21, 2025

Uh oh!

Uh oh!

Uh oh!

fix(button): [select] add button's cssvar and fix select reference slot's problem #2941

fix(button): [select] add button's cssvar and fix select reference slot's problem #2941

Uh oh!

Conversation

shenjunjian commented Feb 21, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Feb 21, 2025

Uh oh!

Uh oh!

Uh oh!

shenjunjian commented Feb 21, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 21, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)