fix(nav-menu): [nav-menu] add dark theme #3097

wuyiping0628 · 2025-03-10T06:55:49Z

PR

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

Style
- Navigation menu now features a clean solid border instead of a shadow.
- Updated dropdown menu styling introduces a refreshed background color.
- Simplified interaction by removing the hover effect on the additional options trigger.
- Color settings have been adjusted for improved consistency in menu highlights.

…dark-0307

coderabbitai · 2025-03-10T06:55:56Z

Walkthrough

This pull request updates the navigational styling in the theme. In the LESS files, a box shadow on the main navigation menu has been replaced with a solid border, the hover effect on the .more-button has been removed, and a hover background variable was eliminated. Additionally, the dropdown menu's background color and the right border color variable have been updated to reflect a disabled state.

Changes

File(s)	Change Summary
`packages/.../nav-menu/index.less`	Replaced box shadow with a solid border and removed `.more-button` hover effect.
`packages/.../nav-menu/vars.less`	Removed the CSS variable for nav menu item hover and updated the dropdown menu background color and right border color variables.

Possibly related PRs

fix(theme): update vars.less comments #2160: The changes in the main PR are related to the removal of the hover background color variable in vars.less, which directly connects to the modifications made in the retrieved PR that also involves updates to the vars.less file.
fix(nav-menu): [nav-menu] Fix the style issue of the nav-menu component #2889: The changes in the main PR are related to the styling of the navigation menu, specifically altering hover effects and borders, while the retrieved PR focuses on padding and margin adjustments in the same navigation menu component.

Suggested labels

enhancement

Suggested reviewers

zzcr

Poem

I'm a rabbit with a hop and a skip,
A fresh new look in every bit of the clip.
No shadows to hide, just crisp borders in sight,
Backgrounds and hovers now feeling just right.
With whiskers twitching in pure delight,
I celebrate these changes with a joyful bite!

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

petercat-assistant · 2025-03-10T06:56:13Z

Walkthrough

This PR introduces a dark theme to the nav-menu component by modifying styles in the LESS files. It replaces certain background and border colors with variables that support the dark theme, ensuring a consistent look and feel.

Changes

Files	Summary
`packages/theme/src/nav-menu/index.less`	Updated styles to replace box-shadow with a border and changed background colors to support dark theme. Removed hover background color.
`packages/theme/src/nav-menu/vars.less`	Removed hover background color variable and updated border color variable to support dark theme.

packages/theme/src/nav-menu/index.less

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

packages/theme/src/nav-menu/vars.less (2)

34-35: Dark Theme: Popmenu Background Variable Added

The new variable --tv-NavMenu-popmenu-box-background: var(--tv-color-bg-hover-4); has been introduced to define the dropdown menu’s background in the dark theme. Please verify that --tv-color-bg-hover-4 is defined in the theme’s color palette and provides adequate contrast and visual consistency in dark mode.

45-45: Style Update: Popmenu More Menu Border Color Change

The update of --tv-NavMenu-popmenu-more-menu-border-color-right to var(--tv-color-border-disabled) should help the dropdown border better match the overall dark theme aesthetics. Please ensure that this modification does not compromise the visual clarity or accessibility of border elements in various display contexts.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between adf4a57 and 26bdcbf.

📒 Files selected for processing (2)

packages/theme/src/nav-menu/index.less (2 hunks)
packages/theme/src/nav-menu/vars.less (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/theme/src/nav-menu/index.less

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: PR E2E Test (pnpm test:e2e3)

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 26bdcbf and 3f5df87.

📒 Files selected for processing (2)

packages/theme/src/nav-menu/index.less (1 hunks)
packages/theme/src/nav-menu/vars.less (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/theme/src/nav-menu/index.less

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: PR E2E Test (pnpm test:e2e3)

🔇 Additional comments (1)

packages/theme/src/nav-menu/vars.less (1)

43-43: Update More Menu Border Color for Disabled State

Line 43 updates the more menu's right border color to var(--tv-color-border-disabled). This change is consistent with a design approach aimed at a more subdued (disabled) look, which can be appropriate for a dark theme. Ensure that this change integrates well with other dark theme elements and does not inadvertently affect any interactive feedback or accessibility considerations.

packages/theme/src/nav-menu/vars.less

MomoPoppy · 2025-03-10T11:09:36Z

packages/theme/src/nav-menu/vars.less

  // 导航菜单栏项选中下划线背景色
  --tv-NavMenu-item-selected-underline-bg-color: var(--tv-color-bg-primary);
  // 导航菜单菜单栏下拉框阴影
  --tv-NavMenu-popmenu-box-shadow: var(--tv-shadow-3-down);
  // 导航菜单菜单栏下拉框选中文本色
  --tv-NavMenu-popmenu-selected-text-color: var(--tv-color-text);
  // 导航菜单菜单栏下拉背景色
-  --tv-NavMenu-popmenu-bg-color: var(--tv-color-bg-3, #fff);
+  --tv-NavMenu-popmenu-bg-color: var(--tv-color-bg-hover-4, #fff);


1 首先场景不对
2 设计规范有关于顶部导航的下拉背景色

MomoPoppy · 2025-03-10T11:15:39Z

packages/theme/src/nav-menu/index.less

@@ -23,7 +23,7 @@
  height: var(--tv-NavMenu-height);
  position: relative;
  padding: 0 var(--tv-NavMenu-padding);
-  box-shadow: 0 1px 3px 1px rgba(0, 0, 0, 0.1);
+  border: 1px solid  var(--tv-color-border-disabled);


1 首先这里要用组件级变量
2 场景不对，这里不是禁用场景的话不该用禁用边框色，而是常规边框色
3 关于阴影，设计规范有暗黑主题的阴影，具体在tokens的表格里

MomoPoppy · 2025-03-10T11:21:20Z

packages/theme/src/nav-menu/vars.less

  // 导航菜单菜单栏下拉框选中字重
  --tv-NavMenu-popmenu-selected-font-weight: var(--tv-font-weight-bold);
  // 导航菜单菜单栏下拉框文本色
  --tv-NavMenu-popmenu-text-color: var(--tv-color-text);
  // 导航菜单更多按钮展示的下拉框右边框色
-  --tv-NavMenu-popmenu-more-menu-border-color-right: var(--tv-color-border);
+  --tv-NavMenu-popmenu-more-menu-border-color-right: var(--tv-color-border-disabled);


场景不对，如果确实是缺场景，要补充对应场景的变量

wuyiping0628 · 2025-03-17T09:37:42Z

重复

Issues-translate-bot · 2025-03-17T09:37:52Z

Bot detected the issue body's language is not English, translate it automatically.

repeat

wuyiping0628 added 2 commits March 9, 2025 23:53

fix(nav-menu): [nav-menu] add dark theme

2dadcd5

Merge branch 'dev' of github.com:opentiny/tiny-vue into wyp/nav-menu-…

adf4a57

…dark-0307

wuyiping0628 added the enhancement New feature or request （功能增强） label Mar 10, 2025

github-actions bot added bug Something isn't working and removed enhancement New feature or request （功能增强） labels Mar 10, 2025

petercat-assistant bot reviewed Mar 10, 2025

View reviewed changes

packages/theme/src/nav-menu/index.less Show resolved Hide resolved

petercat-assistant bot reviewed Mar 10, 2025

View reviewed changes

packages/theme/src/nav-menu/index.less Outdated Show resolved Hide resolved

wuyiping0628 added 2 commits March 10, 2025 00:34

fix(nav-menu): [nav-menu] add dark theme

26bdcbf

fix(nav-menu): [nav-menu] add dark theme

3f5df87

coderabbitai bot reviewed Mar 10, 2025

View reviewed changes

packages/theme/src/nav-menu/vars.less Show resolved Hide resolved

MomoPoppy reviewed Mar 10, 2025

View reviewed changes

wuyiping0628 closed this Mar 17, 2025

wuyiping0628 reopened this Mar 17, 2025

wuyiping0628 closed this Mar 17, 2025

wuyiping0628 deleted the wyp/nav-menu-dark-0307 branch March 17, 2025 09:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(nav-menu): [nav-menu] add dark theme #3097

fix(nav-menu): [nav-menu] add dark theme #3097

wuyiping0628 commented Mar 10, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 10, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

petercat-assistant bot commented Mar 10, 2025

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

MomoPoppy Mar 10, 2025 •

edited

Loading

Uh oh!

MomoPoppy Mar 10, 2025 •

edited

Loading

Uh oh!

MomoPoppy Mar 10, 2025

Uh oh!

wuyiping0628 commented Mar 17, 2025

Uh oh!

Issues-translate-bot commented Mar 17, 2025

Uh oh!

Uh oh!

fix(nav-menu): [nav-menu] add dark theme #3097

fix(nav-menu): [nav-menu] add dark theme #3097

Conversation

wuyiping0628 commented Mar 10, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

petercat-assistant bot commented Mar 10, 2025

Walkthrough

Changes

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MomoPoppy Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MomoPoppy Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MomoPoppy Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

wuyiping0628 commented Mar 17, 2025

Uh oh!

Issues-translate-bot commented Mar 17, 2025

Uh oh!

Uh oh!

wuyiping0628 commented Mar 10, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 10, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

MomoPoppy Mar 10, 2025 •

edited

Loading

MomoPoppy Mar 10, 2025 •

edited

Loading