fix:[checkbox,time-line,steps] fix e2e test and icon modification #3226
Conversation
WalkthroughThis update refines test locators and expected CSS properties in demo test files and adjusts styles in various theme components. The changes include updating the checkbox and timeline test assertions, modifying padding, color fills, line heights, border radii, and CSS variable references across checkbox, dropdown, steps, and tabs styles. No public API changes were made. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
examples/sites/demos/pc/app/checkbox/basic-usage.spec.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. examples/sites/demos/pc/app/time-line/status.spec.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (8)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis PR addresses E2E test fixes and icon modifications for components such as checkbox, time-line, and steps. It includes changes in CSS properties, SVG modifications, and adjustments to test cases to ensure correct visual and functional behavior. Changes
|
| await expect(checkbox).toHaveClass(/is-checked/) | ||
| await expect(checkbox.locator('.tiny-checkbox__inner svg path').first()).toHaveCSS('fill', 'rgb(20, 118, 255)') | ||
| await expect(checkbox.locator('.tiny-checkbox__inner svg path').first()).toHaveCSS('fill', 'rgb(255, 255, 255)') |
There was a problem hiding this comment.
The change in expected CSS fill color from 'rgb(20, 118, 255)' to 'rgb(255, 255, 255)' should be verified to ensure it aligns with the intended design specifications, as it may affect the visual appearance of the checkbox.
| @@ -19,7 +19,7 @@ test('垂直布局', async ({ page }) => { | |||
| await checkedLabelSZ.click() | |||
| await expect(checkedLabelSZ).toHaveClass(/is-checked/) | |||
| const parentWrapper = page.getByLabel('checkbox-group').first() | |||
| await expect(parentWrapper).toHaveCSS('display', 'inline-block') | |||
| await expect(parentWrapper).toHaveCSS('display', 'flex') | |||
There was a problem hiding this comment.
Changing the display property from 'inline-block' to 'flex' can significantly alter the layout. Ensure that this change is intentional and does not disrupt the intended design.
| @@ -11,7 +11,7 @@ test.describe('节点状态', () => { | |||
| // 默认状态 | |||
| await expect(timelineItems.first()).toHaveClass(/process-wait/) | |||
| await expect(timelineItems.first().locator('.icon')).toHaveCSS('border-color', 'rgb(219, 219, 219)') | |||
| await expect(timelineItems.first().locator('.icon .number')).toHaveCSS('color', 'rgb(128, 128, 128)') | |||
| await expect(timelineItems.first().locator('.icon .number')).toHaveCSS('color', 'rgb(25, 25, 25)') | |||
There was a problem hiding this comment.
The change in expected CSS color from 'rgb(128, 128, 128)' to 'rgb(25, 25, 25)' should be verified to ensure it aligns with the intended design specifications, as it may affect the visual appearance of the timeline item.
a35d75b to
42b14f0
Compare
PR
fix:用例修复以及图标修改
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit