Skip to content

fix(calendar-view): [calendar-view] fix e2e erros #3229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2025
Merged

fix(calendar-view): [calendar-view] fix e2e erros #3229

merged 2 commits into from
Apr 1, 2025

Conversation

shenjunjian
Copy link
Collaborator

@shenjunjian shenjunjian commented Apr 1, 2025 •
edited by coderabbitai bot
Loading

PR

修复 calendar-view 的e2e报错

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Tests
    • Enhanced test reliability for the calendar view by refining the selection of disabled day elements.
    • Optimized interaction tests for tree item tags, ensuring more robust validations during tag collapse and expansion.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 1, 2025 •
edited
Loading

Walkthrough

This pull request refines element selection in two test files. In the calendar view test, a scoped locator (wrap) is introduced to more precisely target calendar day elements. In the tree-select collapse-tags test, the selector targeting the path element is replaced with one for an svg element within a checkbox inner container. No public or exported entities were altered.

Changes

File(s) Summary
examples/.../calendar-disabled-day.spec.ts, examples/.../collapse-tags.spec.ts Refactored test selectors for greater specificity: introduced a scoped locator (wrap) for calendar tests to accurately access day elements, and updated tree-select tests by replacing path selectors with svg within .tiny-checkbox__inner.

Possibly related PRs

Suggested labels

bug

Suggested reviewers

  • zzcr

Poem

I'm hopping through the code with glee,
Scoping selectors perfectly for all to see.
With a twitch of my nose, I find each day,
And in tree tests, a new path lights the way.
A bunny cheers in ASCII delight—
Code carrots crunching, making tests just right!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

examples/sites/demos/pc/app/calendar-view/calendar-disabled-day.spec.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

examples/sites/demos/pc/app/tree-select/collapse-tags.spec.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f49aa1 and ecf4d19.

📒 Files selected for processing (2)
  • examples/sites/demos/pc/app/calendar-view/calendar-disabled-day.spec.ts (1 hunks)
  • examples/sites/demos/pc/app/tree-select/collapse-tags.spec.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (3)
examples/sites/demos/pc/app/tree-select/collapse-tags.spec.ts (2)

25-25: Improved selector specificity for tree node interaction.

The selector has been updated to target the SVG element within the checkbox instead of the previously used path element. This change provides more reliable element targeting for the test.

30-31: Consistent selector usage for checkbox interactions.

Good consistency in applying the updated selector pattern across multiple tree item interactions. The change to target the SVG element within .tiny-checkbox__inner makes the test more robust against minor UI implementation changes.

examples/sites/demos/pc/app/calendar-view/calendar-disabled-day.spec.ts (1)

6-11: Enhanced element selection with scoped locators.

Great improvement to the element selection approach. By introducing the wrap locator to target the calendar container first, then accessing day elements through it, you've made the test more robust. This scoping:

  1. Reduces the risk of selecting wrong elements if there are multiple calendars or date elements on the page
  2. Makes the test more maintainable and less prone to breaking with DOM structure changes
  3. Improves readability by clearly showing the relationship between elements
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Apr 1, 2025
@petercat-assistant PeterCat-assistant
Copy link

Walkthrough

This PR addresses issues in the calendar-view component by fixing end-to-end (e2e) test errors. The changes involve updating test selectors to ensure proper element targeting and validation.

Changes

File Summary
calendar-disabled-day.spec.ts Updated test selectors to use a more specific locator for calendar days, ensuring accurate targeting for disabled day checks.
collapse-tags.spec.ts Modified test selectors to use a more specific locator for tree items, ensuring accurate interaction with checkbox elements.

petercat-assistant[bot]
petercat-assistant bot reviewed Apr 1, 2025
View reviewed changes
examples/sites/demos/pc/app/calendar-view/calendar-disabled-day.spec.ts
const day10 = wrap.getByText('10').first()
const day14 = wrap.getByText('14')
const day15 = wrap.getByText('15')

await expect(day10).toHaveClass(/is-disabled/)
await expect(day14).toHaveClass(/is-disabled/)
await expect(day15).toHaveClass('date')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the class 'date' is the intended class for the element. If this is a typo, it may lead to incorrect test validation.

@zzcr zzcr merged commit 9f72b19 into dev Apr 1, 2025
14 of 21 checks passed
@kagol kagol deleted the shen/fix-tree-select-e2e branch April 14, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzcr zzcr zzcr approved these changes

+1 more reviewer

@petercat-assistant petercat-assistant[bot] petercat-assistant[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shenjunjian @zzcr