Skip to content

fix(picker): range-picker add tabindex #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

fix(picker): range-picker add tabindex #3313

merged 1 commit into from
Apr 21, 2025

Conversation

gimmyhehe
Copy link
Member

@gimmyhehe gimmyhehe commented Apr 17, 2025 •
edited by coderabbitai bot
Loading

PR

为range-picker的input添加tabindex

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Accessibility
    • Improved keyboard navigation by setting explicit tab order for start and end input fields in the date/time range picker on both mobile and desktop views.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 17, 2025 •
edited
Loading

Walkthrough

The changes introduce the tabindex="1" attribute to the start and end input fields within the range editor sections of both the mobile and PC variants of a Vue picker component. Additionally, the PC component's code is slightly reformatted by consolidating a multiline <component> tag into a single line, without altering its logic or behavior. No other logic, event handling, or exported entities are changed.

Changes

File(s) Change Summary
packages/vue/src/picker/src/mobile-first.vue Added tabindex="1" to start and end input fields in the ranged date/time picker section.
packages/vue/src/picker/src/pc.vue Added tabindex="1" to start and end range editor inputs; reformatted a <component> tag to single line.

Poem

A hop and a skip on the tabbing trail,
Inputs now line up, neat as a quail.
With tabindex set, navigation’s a breeze,
Both on mobile and PC, jump with ease!
The bunny approves, with a wiggle and cheer—
Keyboard-friendly fields bring springtime near!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/vue/src/picker/src/mobile-first.vue

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

packages/vue/src/picker/src/pc.vue

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Apr 17, 2025
@github-actions GitHub Actions
Copy link

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

coderabbitai[bot]
coderabbitai bot reviewed Apr 17, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
packages/vue/src/picker/src/mobile-first.vue (2)

114-114: Consider using tabindex="0" instead of "1"

While adding tabindex improves keyboard accessibility for the range picker input, using a positive value (tabindex="1") could cause unexpected tab order issues. The same value is used for both inputs, which doesn't establish a clear tab sequence between them.

Consider using tabindex="0" instead to maintain the natural document flow while still making the element focusable:

-          tabindex="1"
+          tabindex="0"

145-145: Consider using tabindex="0" instead of "1"

Using tabindex="1" for both start and end inputs doesn't create a clear tab sequence between them. Additionally, positive tabindex values can disrupt the natural page tab order and create confusion for keyboard users.

For better accessibility, consider using tabindex="0":

-          tabindex="1"
+          tabindex="0"
packages/vue/src/picker/src/pc.vue (2)

102-102: Consider using tabindex="0" instead of "1"

While adding tabindex is an improvement for keyboard accessibility, using positive values (tabindex="1") can interfere with the natural tab order of the page. This could negatively impact keyboard navigation.

For better accessibility, consider using tabindex="0":

-        tabindex="1"
+        tabindex="0"

120-120: Consider using tabindex="0" instead of "1"

Using the same positive tabindex value for both start and end inputs doesn't establish a clear tab sequence between them. For keyboard users, this could be confusing.

Use tabindex="0" for better accessibility:

-        tabindex="1"
+        tabindex="0"

If maintaining a specific order between these two inputs is important, ensure the HTML structure already reflects the desired tab order, as elements with the same tabindex value will be navigated according to their position in the document.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 26709bd and 42ed08f.

📒 Files selected for processing (2)
  • packages/vue/src/picker/src/mobile-first.vue (2 hunks)
  • packages/vue/src/picker/src/pc.vue (3 hunks)
🔇 Additional comments (1)
packages/vue/src/picker/src/pc.vue (1)

63-63: LGTM - Code format improvement

The consolidation of the multiline component tag into a single line improves code readability without changing functionality.

@zzcr zzcr merged commit f301615 into dev Apr 21, 2025
11 checks passed
@zzcr zzcr deleted the cgm/picke-tabindex branch April 21, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@zzcr zzcr zzcr approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gimmyhehe @zzcr