Skip to content

Add Marketplace apis #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add Marketplace apis #1

wants to merge 2 commits into from

Conversation

awgreene
Copy link
Member

@awgreene awgreene commented Aug 9, 2019 •
edited
Loading

This commit introduces the OperatorSource and CatalogSourceConfig APIs
to the project.

awgreene added 2 commits August 9, 2019 09:46
@awgreene
[sdk] Updates directory for use with sdk
39b4c77 
The Marketplace APIs rely on the Operator-SDK to generate the deepcopy
functions with the `operator-sdk generate k8s` command. The
Operator-SDK is picky when it comes to the directory layout when
running its commands. This PR updates the directory to meet the
Operator-SDK requirements and adds the required dependencies.
@awgreene
[apis] Add Marketplace apis
57f5c9f 
This commit introduces the OperatorSource and CatalogSourceConfig APIs
to the project.
@awgreene awgreene changed the title Marketplace apis Add Marketplace apis Aug 9, 2019
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 9, 2019
@estroz
Copy link
Member

estroz commented Sep 24, 2019

Does a global project structure make sense for the api repo, considering that we're adding several projects that have different structural requirements? For example, having a global pkg directory makes sense, but not cmd/manager/main.go.

Perhaps a better construction would be placing all APIs in pkg/apis, and all other project dirs/files in a {project-name} dir. It is possible to have both a global and child go.mod's too, although not recommended.

@estroz estroz mentioned this pull request Sep 24, 2019
Merged
@njhale
Copy link
Member

njhale commented Oct 28, 2019

We may want to drop this if we're not going to follow through w/ moving our APIs to this repo.

(see: #3 (comment))

@ecordell
Copy link
Member

ecordell commented Mar 6, 2020

Plans have changed here - we won't be moving marketplace apis here after all.

@ecordell ecordell closed this Mar 6, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2020
@openshift-ci-robot
Copy link

@awgreene: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

exdx added a commit that referenced this pull request Mar 16, 2021
@exdx
Merge pull request #1 from hasbro17/feat/cleanup-api
c95efc7 
feat: fixup cleanup api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@awgreene @estroz @njhale @ecordell @openshift-ci-robot