Skip to content

fix error on missing icon #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2021
Merged

fix error on missing icon #95

merged 1 commit into from
Jan 28, 2021

Conversation

gallettilance
Copy link
Member

No description provided.

@jmrodri
Copy link
Member

jmrodri commented Jan 28, 2021 •
edited
Loading

Using this patch in the SDK seems to fix the error:

$ /home/devel/jesusr/dev/operator-sdk/build/operator-sdk bundle validate --select-optional name=operatorhub clusterresourceoverride-operator-bundle:v4.6.0
INFO[0000] Unpacking image layers                       
INFO[0000] running /usr/bin/docker pull registry-proxy.engineering.redhat.com/rh-osbs/openshift-ose-clusterresourceoverride-operator-bundle:v4.6.0.202101230113.p0-1 
INFO[0000] running docker create                        
INFO[0000] running docker cp                            
INFO[0000] running docker rm                            
INFO[0000] Found annotations file                        bundle-dir=/tmp/bundle-214871157 container-tool=docker
INFO[0000] Could not find optional dependencies file     bundle-dir=/tmp/bundle-214871157 container-tool=docker
WARN[0000] Warning: Value : (clusterresourceoverride-operator.4.6.0-202101230113.p0) csv.Spec.Icon not specified 
INFO[0000] All validation tests have completed successfully

kevinrizza
kevinrizza reviewed Jan 28, 2021
View reviewed changes
pkg/validation/internal/operatorhub.go
var errs []error
var warns []error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the wrong type to use? We're not overloading any of the error methods here at all (or implementing anything special on top), and we're ultimately just calling warn.Error() to get the string back out. Seems like this could just be a slice of strings?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinrizza it looks like he was just reusing what was already there. The logic assumes a slice of errors. But what you suggest is more correct because the strings are passed into specific Errors. +1 to using []string but will that mess anything else up?

@gallettilance gallettilance merged commit f8c87b6 into operator-framework:master Jan 28, 2021
@gallettilance gallettilance deleted the operatorhub-icon-fix branch January 28, 2021 21:13
@estroz
Copy link
Member

estroz commented Feb 1, 2021

/cherry-pick v0.4.x

@openshift-cherrypick-robot
Copy link

@estroz: new pull request could not be created: failed to create pull request against operator-framework/api#openshift-cherrypick-robot:cherry-pick-95-to-v0.4.x from v0.4.x: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","field":"head","code":"invalid"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick v0.4.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estroz estroz mentioned this pull request Feb 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri left review comments

@kevinrizza kevinrizza kevinrizza left review comments

@Bowenislandsong Bowenislandsong Awaiting requested review from Bowenislandsong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gallettilance @jmrodri @estroz @openshift-cherrypick-robot @kevinrizza