Skip to content

🌱 bump to go1.23 #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 13, 2025
Merged

🌱 bump to go1.23 #386

merged 4 commits into from
Jan 13, 2025

Conversation

perdasilva
Copy link
Contributor

No description provided.

@perdasilva
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2024
@perdasilva perdasilva marked this pull request as draft September 13, 2024 08:10
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2024
Bump to go1.23
ebe469e 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2025
@perdasilva perdasilva changed the title 🌱 bump go version to v1.23.0 🌱 bump to go1.23 Jan 9, 2025
@acornett21
Copy link
Contributor

@perdasilva The lint version needs to be updated to v1.62.2 or higher.

Per Goncalves da Silva added 2 commits January 9, 2025 16:54
Update bingo deps
83008fd 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Address lint errors
14d1421 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Fix up golangci-lint version in GHA
aa09a65 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.48%. Comparing base (08ab7fb) to head (aa09a65).
Report is 66 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (08ab7fb) and HEAD (aa09a65). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (08ab7fb) HEAD (aa09a65)
2 1
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
- Coverage   85.06%   78.48%   -6.59%     
==========================================
  Files          19       31      +12     
  Lines        1346     2477    +1131     
==========================================
+ Hits         1145     1944     +799     
- Misses        125      444     +319     
- Partials       76       89      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acornett21
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@perdasilva
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2025
@perdasilva perdasilva marked this pull request as ready for review January 13, 2025 09:05
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2025
@openshift-ci openshift-ci bot requested review from fabianvf and porridge January 13, 2025 09:05
@perdasilva perdasilva added this pull request to the merge queue Jan 13, 2025
Merged via the queue into operator-framework:main with commit 6c94115 Jan 13, 2025
6 checks passed
@perdasilva perdasilva deleted the perdasilva/bump/go branch January 13, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acornett21 acornett21 acornett21 approved these changes

@everettraven everettraven Awaiting requested review from everettraven

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

@fabianvf fabianvf Awaiting requested review from fabianvf

@porridge porridge Awaiting requested review from porridge

Assignees

@acornett21 acornett21

Labels
area/deps area/infra area/sdk area/testing lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@perdasilva @acornett21 @codecov-commenter @openshift-merge-robot