pkg/client: add history method to ActionClient #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to give users of this library more information about the state of a release, we are adding the `History` method to the `ActionClient` interface. Without this, the only information is available via the `ActionClient` about a release is the latest revision (via the `Get` method). However this proves insufficient if callers need to know details of release history, for example if an upgrade failed and callers want to know about the most recently deployed release. Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
7b26a3c to
e3aa77e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #397 +/- ##
==========================================
- Coverage 85.06% 79.69% -5.37%
==========================================
Files 19 31 +12
Lines 1346 1980 +634
==========================================
+ Hits 1145 1578 +433
- Misses 125 313 +188
- Partials 76 89 +13 ☔ View full report in Codecov by Sentry. |
everettraven
approved these changes
Oct 15, 2024
Merged
via the queue into
operator-framework:main
with commit Oct 15, 2024
67f6398
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to give users of this library more information about the state of a release, we are adding the
Historymethod to theActionClientinterface.Without this, the only information available via the
ActionClientabout a release is the latest revision (via theGetmethod). However this proves insufficient if callers need to know details of release history, for example if an upgrade failed and callers want to know about the most recently deployed release.