fix: Resolve race condition between visited flag and result of ready postcondition #2886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Kłoskowski <adrian.kloskowski@ds.pl>
67a85d9 to
88ca3eb
Compare
xstefank
approved these changes
Aug 7, 2025
|
Makes sense, thank you @ds-akloskowski |
csviri
approved these changes
Aug 7, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for a problem described in #2885.
The changed code causes that when
visitedflag is changed to true, we are sure that readyPostconditionResult was checked before. In previous version,visitedflag set to true and readyPostconditionResult equals null could describe two situations:The changed code doesn't let the second situation to happen.