Skip to content

fix: do not run extension on abstract controllers #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 22, 2021
Merged

fix: do not run extension on abstract controllers #347

merged 3 commits into from
Feb 22, 2021

Conversation

metacosm
Copy link
Collaborator

Fixes #346

goldmann
goldmann reviewed Feb 22, 2021
View reviewed changes
...-quarkus-extension/tests/src/main/java/io/javaoperatorsdk/quarkus/it/AbstractController.java Outdated
return null;
}

/*
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this could be removed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed :)

@metacosm metacosm merged commit 6b696ec into master Feb 22, 2021
@metacosm metacosm deleted the fix-346 branch February 22, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@goldmann goldmann goldmann approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IllegalArgumentException when using Quarkus extension with abstract classes
2 participants
@metacosm @goldmann