🌱 (cleanup): Centralize the utils func under the test/utils directories #1742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ad34ffb to
183a795
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1742 +/- ##
==========================================
- Coverage 67.39% 67.34% -0.06%
==========================================
Files 61 61
Lines 5236 5236
==========================================
- Hits 3529 3526 -3
- Misses 1447 1449 +2
- Partials 260 261 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
test/catalogd-e2e/unpack_test.go
Outdated
| @@ -14,6 +14,7 @@ import ( | |||
| "k8s.io/apimachinery/pkg/types" | |||
|
|
|||
| catalogdv1 "github.com/operator-framework/operator-controller/catalogd/api/v1" | |||
| "github.com/operator-framework/operator-controller/test/utils" | |||
There was a problem hiding this comment.
nitpick : can we import this as testutil? because we already have internal/util in code.
| @@ -21,7 +21,7 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/client" | |||
|
|
|||
| catalogdv1 "github.com/operator-framework/operator-controller/catalogd/api/v1" | |||
| catalogde2e "github.com/operator-framework/operator-controller/test/catalogd-e2e" | |||
| "github.com/operator-framework/operator-controller/test/utils" | |||
There was a problem hiding this comment.
Same as above
nitpick : can we import this as testutil? because we already have internal/util in code.
183a795 to
2de594c
Compare
2de594c to
c4c6da2
Compare
Merged
via the queue into
operator-framework:main
with commit Feb 11, 2025
6dace7c
19 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reviewer Checklist