🌱 Add an overlay for local development on Tilt #1773
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Adds an overlay that removes the liveness and readiness probes as well as the --leader-elect flag from the operator-controller-controller-manager deployment since those will cause container restarts when the go debugger is stopped at breakpoints. Also edits the Tiltfile to use this new overlay target. Also adds our 1 existing feature flag to the new overlay. Signed-off-by: Tayler Geiger <tayler@redhat.com>
706c868 to
b387cf5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1773 +/- ##
=======================================
Coverage 68.29% 68.29%
=======================================
Files 63 63
Lines 5116 5116
=======================================
Hits 3494 3494
Misses 1392 1392
Partials 230 230
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| path: /spec/template/spec/containers/0/args/2 | ||
| - op: add | ||
| path: /spec/template/spec/containers/0/args/- | ||
| value: --feature-gates=PreflightPermissions=true |
There was a problem hiding this comment.
probably ok for now, but we may want to start to think about how to handle this when we have multiple fgs. Maybe one patch / fg?
There was a problem hiding this comment.
It is a good thought
There was a problem hiding this comment.
Yeah that's a good idea. I also just wasn't sure if we wanted to auto enable the feature flags for dev env or have individual devs manually write patches for them locally but thought i'd just throw this one in and see. I can separate it out into its own patch now before merge if you want, but you also approved it so can hold off until we have another one in the future.
There was a problem hiding this comment.
Saw this yesterday afternoon, but it was too late in the day for me to say "hey please also add APIV1MetasHandler for catalogd". :)
IMHO merge this and then I'll add that separately. Would be good for me to learn more about overlays anyway.
Adds an overlay that removes the liveness and readiness probes as well as the --leader-elect flag from the operator-controller-controller-manager deployment since those will cause container restarts when the go debugger is stopped at breakpoints. Also edits the Tiltfile to use this new overlay target.
Also adds our 1 existing feature flag to the new overlay.
Description
Reviewer Checklist