Skip to content

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Feb 18, 2025

Followup to #1790

This is a cleanup commit to allow the verify-crd-compatibility target to continue working through the config consoldiation effort.

This updates the verify-crd-compatibility recipe to target the new CRD locations and removes the CRDs from the old locations.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner February 18, 2025 20:16
Copy link

netlify bot commented Feb 18, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit a288bee
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67b60687b45086000904587d
😎 Deploy Preview https://deploy-preview-1791--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tmshort
Copy link
Contributor Author

tmshort commented Feb 18, 2025

This is expected to fail until #1790 is merged, and this PR is rebased.

@tmshort tmshort changed the title OPRUN-1722: Remove CRDs from old locations 🌱 OPRUN-1722: Remove CRDs from old locations Feb 18, 2025
@tmshort tmshort changed the title 🌱 OPRUN-1722: Remove CRDs from old locations 🌱 OPRUN-3722: Remove CRDs from old locations Feb 18, 2025
This is a cleanup commit to allow the verify-crd-compatibility target
to continue working through the config consoldiation effort.

This updates the verify-crd-compatibility recipe to target the new
CRD locations and removes the CRDs from the old locations.

Signed-off-by: Todd Short <tshort@redhat.com>
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.34%. Comparing base (2a5e9b8) to head (a288bee).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1791   +/-   ##
=======================================
  Coverage   68.34%   68.34%           
=======================================
  Files          63       63           
  Lines        5117     5117           
=======================================
  Hits         3497     3497           
  Misses       1390     1390           
  Partials      230      230           
Flag Coverage Δ
e2e 51.62% <ø> (ø)
unit 55.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2025
@tmshort tmshort added this pull request to the merge queue Feb 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 19, 2025
@joelanford joelanford added this pull request to the merge queue Feb 19, 2025
Merged via the queue into operator-framework:main with commit 7040ee2 Feb 19, 2025
20 checks passed
@tmshort tmshort deleted the finish-crd branch February 19, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants