Skip to content

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Feb 25, 2025

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort requested a review from a team as a code owner February 25, 2025 21:21
Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit c171d69
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67be344ada68f10008eef735
😎 Deploy Preview https://deploy-preview-1812--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tmshort tmshort enabled auto-merge February 25, 2025 21:23
@tmshort
Copy link
Contributor Author

tmshort commented Feb 25, 2025

Closing in favor of #1813

@tmshort tmshort closed this Feb 25, 2025
auto-merge was automatically disabled February 25, 2025 21:33

Pull request was closed

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.32%. Comparing base (3921e24) to head (c171d69).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1812      +/-   ##
==========================================
- Coverage   68.37%   68.32%   -0.06%     
==========================================
  Files          62       62              
  Lines        5117     5117              
==========================================
- Hits         3499     3496       -3     
- Misses       1389     1391       +2     
- Partials      229      230       +1     
Flag Coverage Δ
e2e 51.62% <ø> (-0.08%) ⬇️
unit 55.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort tmshort deleted the rm-catalogd branch June 26, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant