Skip to content

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Feb 25, 2025

Use OPCON and CATD abbreviations to make things shorter (OPERATOR_CONTROLLER is quite long...)

Also, clean up .gitignore to remove references of the catalogd directory.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Use OPCON and CATD abbreviations

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort requested a review from a team as a code owner February 25, 2025 21:48
Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 4780d7a
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67be3aa42d3096000884e8e8
😎 Deploy Preview https://deploy-preview-1814--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.34%. Comparing base (3921e24) to head (4780d7a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1814      +/-   ##
==========================================
- Coverage   68.37%   68.34%   -0.04%     
==========================================
  Files          62       62              
  Lines        5117     5117              
==========================================
- Hits         3499     3497       -2     
- Misses       1389     1390       +1     
- Partials      229      230       +1     
Flag Coverage Δ
e2e 51.62% <ø> (-0.08%) ⬇️
unit 55.91% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford joelanford added this pull request to the merge queue Feb 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 25, 2025
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2025
@LalatenduMohanty LalatenduMohanty added this pull request to the merge queue Feb 26, 2025
Merged via the queue into operator-framework:main with commit 6cf1853 Feb 26, 2025
18 of 19 checks passed
@tmshort tmshort deleted the tidy-makefile branch February 26, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants