Skip to content

Conversation

grokspawn
Copy link
Contributor

Description

Adds initial 'personas' distilled from the somehow-unshareable miro board. This arises from review of #1796 and discussion in community and maintainer meetings, replacing it, adding background and role detail.

To-do (this or follow-ups)

  1. add less abrupt intro
  2. make the role descriptions more consistent but less-repeat-y: "this role encompasses..." is blech. Maybe "A <<role>> is..."
  3. reframe this as an operator-framework concern instead of a v1-only one?

Reviewer Checklist

  • [n/a] API Go Documentation
  • [n/a] Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@grokspawn grokspawn requested a review from a team as a code owner February 28, 2025 20:05
Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 753cf8b
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67c5d62137cce4000833a10a
😎 Deploy Preview https://deploy-preview-1824--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@grokspawn grokspawn changed the title initial personas draft 📖 initial personas draft Feb 28, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.44%. Comparing base (58eec48) to head (753cf8b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1824   +/-   ##
=======================================
  Coverage   68.44%   68.44%           
=======================================
  Files          63       63           
  Lines        5134     5134           
=======================================
  Hits         3514     3514           
  Misses       1390     1390           
  Partials      230      230           
Flag Coverage Δ
e2e 51.57% <ø> (ø)
unit 56.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few nits.
Otherwise, it seems fine for me 👍
Great work

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@grokspawn grokspawn force-pushed the personas-distillation branch from 87deab0 to 753cf8b Compare March 3, 2025 16:17
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I am OK with

@michaelryanpeter would you like to give a look on this one?
WDYT?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2025
@grokspawn grokspawn added this pull request to the merge queue Mar 3, 2025
@grokspawn grokspawn removed this pull request from the merge queue due to a manual request Mar 3, 2025
@grokspawn
Copy link
Contributor Author

Whoops. Missed the approval. Waiting to see if @michaelryanpeter wants to nibble on this as opposed to a later revision.

@grokspawn grokspawn added this pull request to the merge queue Mar 3, 2025
Merged via the queue into operator-framework:main with commit 63472e0 Mar 3, 2025
20 checks passed
@grokspawn grokspawn deleted the personas-distillation branch March 3, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants