Skip to content

🌱 Add catalogd to code coverage #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

🌱 Add catalogd to code coverage #2026

merged 1 commit into from
Jun 12, 2025

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jun 12, 2025

Needed to add coverage options to the catalogd deployment.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
Add catalogd to code coverage
ce77f3c 
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort requested a review from a team as a code owner June 12, 2025 20:24
@netlify Netlify
Copy link

netlify bot commented Jun 12, 2025 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit ce77f3c
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/684b37881b378a0008fff102
😎 Deploy Preview https://deploy-preview-2026--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort
Copy link
Contributor Author

tmshort commented Jun 12, 2025

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2025
@joelanford
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.95%. Comparing base (1a27741) to head (ce77f3c).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2026      +/-   ##
==========================================
+ Coverage   69.28%   72.95%   +3.67%     
==========================================
  Files          79       79              
  Lines        7051     7051              
==========================================
+ Hits         4885     5144     +259     
+ Misses       1884     1591     -293     
- Partials      282      316      +34
Flag Coverage Δ
e2e 43.25% <ø> (+0.30%) ⬆️
unit 60.17% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-bot openshift-merge-bot bot merged commit 3441d90 into operator-framework:main Jun 12, 2025
22 of 23 checks passed
@tmshort tmshort deleted the patch-cov branch June 12, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford Awaiting requested review from joelanford

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees

@joelanford joelanford

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmshort @joelanford