✨ Add standard-e2e manifest #2056
Conversation
This renames two overlays: * cert-manager -> standard * e2e -> standard-e2e This also adds a new manifest: * manifests/standard-e2e.yaml This fixes the issue with the current test-e2e modifying the standard manifest with e2e parameters, leaving a dirty workspace. This changes the manifest used by the e2e test to be it's own standard-e2e manifest. This is part of the feature-gated API functionality. Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2056 +/- ##
==========================================
+ Coverage 73.80% 73.82% +0.01%
==========================================
Files 81 81
Lines 7365 7365
==========================================
+ Hits 5436 5437 +1
+ Misses 1589 1588 -1
Partials 340 340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Had a side-channel convo with @tmshort about possible impacts to plans to open up the PKI model to accept other providers (for instance, currently we rely very heavily on certmanager, but others could be used like openshift/serviceca). It sounds like we need to resolve that question separately, and that any change to that would inescapably require new changes to this area anyway, so no opportunity to "leave room" for it here. /lgtm |
089aa45
into
operator-framework:main
|
@grokspawn openshift's serviceca is already handled by separate downstream overlays; so it certainly is possible. By keeping the cert-manager items separate (they are in the |
This renames two overlays:
This also adds a new manifest:
This fixes the issue with the current test-e2e modifying the standard manifest with e2e parameters, leaving a dirty workspace. This changes the manifest used by the e2e test to be it's own standard-e2e manifest.
This is part of the feature-gated API functionality.
Description
Reviewer Checklist