Skip to content

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jun 26, 2025

Move the current feature overlays to be components. This will allow them to be brought into an experimental overlay in the near future.

These are currently unused.

This is part of the feature-gated API functionality.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Move the current feature overlays to be components. This will allow
them to be brought into an experimental overlay in the near future.

These are currently unused.

This is part of the feature-gated API functionality.

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort requested a review from a team as a code owner June 26, 2025 19:35
Copy link

netlify bot commented Jun 26, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 289e68d
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/685da0fab733180008bcc180
😎 Deploy Preview https://deploy-preview-2059--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort
Copy link
Contributor Author

tmshort commented Jun 26, 2025

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.15%. Comparing base (089aa45) to head (289e68d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2059      +/-   ##
==========================================
- Coverage   73.80%   70.15%   -3.66%     
==========================================
  Files          81       81              
  Lines        7365     7365              
==========================================
- Hits         5436     5167     -269     
- Misses       1589     1895     +306     
+ Partials      340      303      -37     
Flag Coverage Δ
e2e 36.03% <ø> (-8.04%) ⬇️
unit 60.23% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Copy link
Contributor Author

tmshort commented Jun 26, 2025

Wow... look at codecov.... changing by 3% when there's no code changes...

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2025
Copy link

openshift-ci bot commented Jun 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Contributor

/lgtm

@tmshort tmshort merged commit 2c585f7 into operator-framework:main Jun 26, 2025
19 of 21 checks passed
@tmshort tmshort deleted the move-features branch June 26, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants