Skip to content

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jun 27, 2025

At the root of each CRD directory, there is a kustomization file. Replicate this into the individual directories, so that they can be referenced directly by overlays.

This keeps the "default" reference of config/base/.../crd to be the standard CRD for compatibility with existing overlays.

The kustomizeconfig.yaml file is not used, and is deleted.

This is part of the feature-gated API functionality.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

At the root of each CRD directory, there is a kustomization file.
Replicate this into the individual directories, so that they can be
referenced directly by overlays.

This keeps the "default" reference of `config/base/.../crd` to be the
standard CRD for compatibility with existing overlays.

The kustomizeconfig.yaml file is not used, and is deleted.

This is part of the feature-gated API functionality.

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort requested a review from a team as a code owner June 27, 2025 13:00
@openshift-ci openshift-ci bot requested review from kevinrizza and oceanc80 June 27, 2025 13:00
Copy link

netlify bot commented Jun 27, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 67e1cc8
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/685e960631d5e300084d7334
😎 Deploy Preview https://deploy-preview-2061--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort
Copy link
Contributor Author

tmshort commented Jun 27, 2025

/approve

Copy link

openshift-ci bot commented Jun 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2025
@camilamacedo86
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 30fb077 into operator-framework:main Jun 27, 2025
19 checks passed
@tmshort tmshort deleted the organize-crds branch June 27, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants