Skip to content

🌱 Update config readme #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

🌱 Update config readme #2065

merged 1 commit into from
Jun 30, 2025

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jun 30, 2025

Also update config comments to make it clear where features are supposed to be listed.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner June 30, 2025 13:32
@netlify Netlify
Copy link

netlify bot commented Jun 30, 2025 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 4fe6be0
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6862948380af260008a92ffa
😎 Deploy Preview https://deploy-preview-2065--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort tmshort force-pushed the update-readme branch 3 times, most recently from 384d7d5 to ffcdb79 Compare June 30, 2025 13:39
@tmshort
Update config readme
4fe6be0 
Also update config comments to make it clear where features are
supposed to be listed.

Signed-off-by: Todd Short <tshort@redhat.com>
@codecov Codecov
Copy link

codecov bot commented Jun 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.90%. Comparing base (6465e63) to head (4fe6be0).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2065      +/-   ##
==========================================
+ Coverage   73.89%   73.90%   +0.01%     
==========================================
  Files          81       81              
  Lines        7365     7365              
==========================================
+ Hits         5442     5443       +1     
+ Misses       1585     1584       -1     
  Partials      338      338
Flag Coverage Δ
e2e 44.06% <ø> (ø)
experimental-e2e 20.14% <ø> (ø)
unit 60.25% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Copy link
Contributor Author

tmshort commented Jun 30, 2025

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2025
camilamacedo86
camilamacedo86 approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5686577 into operator-framework:main Jun 30, 2025
23 checks passed
@tmshort tmshort deleted the update-readme branch June 30, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@gallettilance gallettilance Awaiting requested review from gallettilance

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmshort @camilamacedo86