🌱 Update additional cert-manager locations to v1.18.2 #2071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The go.mod version of cert-manager was updated to v1.18.2 Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/approve |
camilamacedo86
approved these changes
Jul 3, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -5,7 +5,7 @@ load('ext://cert_manager', 'deploy_cert_manager') | |||
| def deploy_cert_manager_if_needed(): | |||
| cert_manager_var = '__CERT_MANAGER__' | |||
| if os.getenv(cert_manager_var) != '1': | |||
| deploy_cert_manager(version="v1.15.3") | |||
| deploy_cert_manager(version="v1.18.2") | |||
There was a problem hiding this comment.
It would be nice if it could read the value from the Makefile, so we do not forget to update it.
Anyway, it is a very small, nice-to-have, so I will not block this one due to it
We can improve in follow up always :-)
/lgtm
245fc52
into
operator-framework:main
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go.mod version of cert-manager was updated to v1.18.2
Description
Reviewer Checklist