🌱 Move registry to registry:3 and make in-cluster registry visibile to kubelet #2080
Conversation
3b0df4c to
ef32061
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2080 +/- ##
==========================================
+ Coverage 73.38% 73.43% +0.04%
==========================================
Files 77 77
Lines 7076 7076
==========================================
+ Hits 5193 5196 +3
+ Misses 1542 1540 -2
+ Partials 341 340 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
...containerd/certs.d/docker-registry.operator-controller-e2e.svc.cluster.local:5000/hosts.toml
Show resolved
Hide resolved
|
is the EXPOSE line in the old registry/push Dockerfile still needed? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ef32061 to
c95a897
Compare
|
/lgtm |
…o kubelet Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
c95a897 to
8bc6518
Compare
|
New changes are detected. LGTM label has been removed. |
eb4b979
into
operator-framework:main
Description
Updates the image registry we use for e2e tests to be the registry:3 image (and removes our homegrown registry) and updates the kind cluster config to route
docker-registry.operator-controller-e2e.svc.cluster.local:5000registry through localhost:30000 (the node port exposed by the kind config for the registry).The main motivation is to make images served by the registry usable for creating pods on the cluster. This is a precondition for the test-operator work, which will have its own controller image.
Test
Reviewer Checklist