Skip to content

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jul 8, 2025

This makes tilt use the equivalent of the experimental manifest with the additional patches.

Git seems to get confused about the rename because the two patch files are identical.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

This makes tilt use the equivalent of the experimental manifest with
the additional patches.

Git seems to get confused about the rename because the two patch
files are identical.

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort requested a review from a team as a code owner July 8, 2025 18:25
Copy link

netlify bot commented Jul 8, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 587a46c
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/686d62b202749d000886c053
😎 Deploy Preview https://deploy-preview-2082--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@joelanford
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2025
Copy link

openshift-ci bot commented Jul 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2025
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.43%. Comparing base (eb4b979) to head (587a46c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2082      +/-   ##
==========================================
+ Coverage   73.33%   73.43%   +0.09%     
==========================================
  Files          77       77              
  Lines        7076     7076              
==========================================
+ Hits         5189     5196       +7     
+ Misses       1545     1540       -5     
+ Partials      342      340       -2     
Flag Coverage Δ
e2e 44.95% <ø> (+0.04%) ⬆️
experimental-e2e 51.20% <ø> (+0.04%) ⬆️
unit 58.39% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Copy link
Contributor Author

tmshort commented Jul 8, 2025

The codecov website is showing 73.43% coverage... so not sure why it's reporting poorly.

@tmshort tmshort merged commit 1b159f6 into operator-framework:main Jul 8, 2025
31 of 35 checks passed
@tmshort tmshort deleted the tilt2 branch July 8, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants