🌱 Remove synthetic auth from experimental manifests #2092
Conversation
Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| @@ -8,7 +8,6 @@ resources: | |||
| components: | |||
| - ../common | |||
| # EXPERIMENTAL FEATURES ARE LISTED HERE | |||
| - ../../features/synthetic-user-permissions | |||
There was a problem hiding this comment.
Could you please add a description about why we should remove it?
There was a problem hiding this comment.
I can add it to the description of the PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2092 +/- ##
=======================================
Coverage 73.49% 73.49%
=======================================
Files 78 78
Lines 7240 7240
=======================================
Hits 5321 5321
Misses 1567 1567
Partials 352 352
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm But I agree with Camila, might be worth adding some words in the description for the motivation |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
36699ab
into
operator-framework:main
We are not planning on doing the synthetic auth in light of the boxcutter effort.
Description
Reviewer Checklist