Skip to content

🌱 Replace assert with require #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

🌱 Replace assert with require #2112

merged 1 commit into from
Jul 22, 2025

Conversation

perdasilva
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2025
@netlify Netlify
Copy link

netlify bot commented Jul 21, 2025 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit b21f632
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/687f70b2cc1c580008a5e510
😎 Deploy Preview https://deploy-preview-2112--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@perdasilva perdasilva changed the title 🌱 Remove assert 🌱 Replace assert with require Jul 21, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.59%. Comparing base (b5a475a) to head (b21f632).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2112      +/-   ##
==========================================
- Coverage   73.60%   73.59%   -0.02%     
==========================================
  Files          78       78              
  Lines        7260     7260              
==========================================
- Hits         5344     5343       -1     
- Misses       1566     1567       +1     
  Partials      350      350
Flag Coverage Δ
e2e 43.72% <ø> (+0.04%) ⬆️
experimental-e2e 56.38% <ø> (ø)
unit 58.82% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2025
Remove assert in favor of require
b21f632 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2025
@perdasilva perdasilva marked this pull request as ready for review July 22, 2025 11:06
@perdasilva perdasilva requested a review from a team as a code owner July 22, 2025 11:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2025
@openshift-ci openshift-ci bot requested review from grokspawn and thetechnick July 22, 2025 11:06
camilamacedo86
camilamacedo86 approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🥇
Thank you 👍

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 86e4ce9 into operator-framework:main Jul 22, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@grokspawn grokspawn Awaiting requested review from grokspawn

@thetechnick thetechnick Awaiting requested review from thetechnick

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perdasilva @camilamacedo86 @openshift-merge-robot