Adds new Status condition "Resolved" and related status field "resolvedBundleResource" to Operator CR #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50dd855 to
f28c545
Compare
tmshort
approved these changes
May 15, 2023
api/v1alpha1/operator_types.go
Outdated
|
|
||
| ReasonInstallationSucceeded = "InstallationSucceeded" | ||
| ReasonResolutionFailed = "ResolutionFailed" | ||
| ReasonResolutionUnknown = "ResolutionUnknown" |
There was a problem hiding this comment.
Nit: these ought to be alphabetical, but others are not. :(
This commits adds a new status conditions: "Resolved" that represent if the Operator-Controller was able to resolv the desired operator image or not. Also, extends the status with a new field: "resolvedBundleResource" that contains the resolved operator image. Signed-off-by: Joaquim Moreno Prusi <joaquim@redhat.com>
Signed-off-by: Joaquim Moreno Prusi <joaquim@redhat.com>
f28c545 to
c6a638a
Compare
|
Still looks good to me. Merging since it's kinda-sorta blocking #201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the status conditions of the Operator CR and adds a new status field.
Fixes #202
Reviewer Checklist