Skip to content

🌱 Separate the (experimental-)e2e coverage #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2025
Merged

🌱 Separate the (experimental-)e2e coverage #2130

merged 1 commit into from
Aug 1, 2025

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jul 31, 2025

Give the experimental-e2e it's own set of output files for coverage vs the regular e2e.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
Separate the (experimental-)e2e coverage
d1bcf62 
Give the experimental-e2e it's own set of output files for coverage vs the
regular e2e.
@tmshort tmshort requested a review from a team as a code owner July 31, 2025 17:07
@netlify Netlify
Copy link

netlify bot commented Jul 31, 2025 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit d1bcf62
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/688ba2d5dd873d0008324716
😎 Deploy Preview https://deploy-preview-2130--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot requested review from dtfranz and trgeiger July 31, 2025 17:07
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.59%. Comparing base (e9c5b6e) to head (d1bcf62).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2130      +/-   ##
==========================================
- Coverage   73.60%   73.59%   -0.02%     
==========================================
  Files          78       78              
  Lines        7260     7260              
==========================================
- Hits         5344     5343       -1     
- Misses       1566     1567       +1     
  Partials      350      350
Flag Coverage Δ
e2e 43.50% <ø> (+0.04%) ⬆️
experimental-e2e 56.17% <ø> (ø)
unit 58.87% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2025
camilamacedo86
camilamacedo86 approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@camilamacedo86
Copy link
Contributor

/approved

@camilamacedo86
Copy link
Contributor

/approve

@dtfranz
Copy link
Contributor

dtfranz commented Aug 1, 2025 •
edited
Loading

If my understanding is correct, since Makefile is in the root dir with the root OWNERS it means only one of these people can approve this PR due to #2113 :
OWNERS :

approvers:
   - olmv1-approvers

OWNERS_ALIASES :

   olmv1-approvers:
   - joelanford
   - kevinrizza
   - perdasilva
   - tmshort

Feels to me like ci-approvers should be able to approve changes to the Makefile 🤔

joelanford
joelanford approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, grokspawn, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e0b5c18 into operator-framework:main Aug 1, 2025
21 checks passed
@tmshort tmshort deleted the experimental-e2e branch August 1, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@grokspawn grokspawn grokspawn approved these changes

@dtfranz dtfranz Awaiting requested review from dtfranz

@trgeiger trgeiger Awaiting requested review from trgeiger

Assignees

@joelanford joelanford

@camilamacedo86 camilamacedo86

@grokspawn grokspawn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tmshort @camilamacedo86 @dtfranz @joelanford @grokspawn