🌱 Update e2e tests for boxcutter #2136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2136 +/- ##
=======================================
Coverage 72.79% 72.79%
=======================================
Files 79 79
Lines 7340 7340
=======================================
Hits 5343 5343
- Misses 1647 1651 +4
+ Partials 350 346 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9483dd9 to
db765c3
Compare
joelanford
reviewed
Aug 5, 2025
joelanford
reviewed
Aug 5, 2025
joelanford
reviewed
Aug 5, 2025
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Modify the `RecoversFromInitialInstallFailedWhenFailureFixed` test to instead not create the namespace and service account, instead of having bad service account. Boxcutter will ignore the service account. Add `RecoversFromExsitingDeploymentWhenFailureFixed` test to ensure we don't adopt, and instead fail when there's an existing resource that matches the bundle (i.e. don't adopt), Signed-off-by: Todd Short <tshort@redhat.com>
|
/lgtm |
108d7e8
into
operator-framework:main
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the
RecoversFromInitialInstallFailedWhenFailureFixedtest to instead not create the namespace and service account, instead of having bad service account. Boxcutter will ignore the service account.Add
RecoversFromExsitingDeploymentWhenFailureFixedtest to ensure we don't adopt, and instead fail when there's an existing resource that matches the bundle (i.e. don't adopt),Description
Reviewer Checklist