Skip to content

🐛 Fix downstream e2e test compatibility #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

🐛 Fix downstream e2e test compatibility #2144

merged 1 commit into from
Aug 12, 2025

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Aug 12, 2025

  • Update busybox deployment SecurityContext
  • Don't panic at end of e2e test if PrintSummary fails

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
Fix downstream e2e test compatibility
f510955 
* Update busybox deployment SecurityContext
* Don't panic at end of e2e test if PrintSummary fails

Signed-off-by: Todd Short <todd.short@me.com>
@tmshort tmshort requested a review from a team as a code owner August 12, 2025 12:28
@openshift-ci openshift-ci bot requested review from joelanford and oceanc80 August 12, 2025 12:28
@netlify Netlify
Copy link

netlify bot commented Aug 12, 2025 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit f510955
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/689b337b833b700008d9e671
😎 Deploy Preview https://deploy-preview-2144--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov Codecov
Copy link

codecov bot commented Aug 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.77%. Comparing base (3aede53) to head (f510955).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2144      +/-   ##
==========================================
- Coverage   72.79%   72.77%   -0.02%     
==========================================
  Files          79       79              
  Lines        7340     7340              
==========================================
- Hits         5343     5342       -1     
- Misses       1651     1652       +1     
  Partials      346      346
Flag Coverage Δ
e2e 44.43% <ø> (+0.09%) ⬆️
experimental-e2e 54.96% <ø> (ø)
unit 58.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort tmshort mentioned this pull request Aug 12, 2025
Merged
4 tasks
camilamacedo86
camilamacedo86 approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Aug 12, 2025

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 3d6a33b into operator-framework:main Aug 12, 2025
22 checks passed
@tmshort tmshort deleted the fix-ds-e2e branch August 12, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@oceanc80 oceanc80 Awaiting requested review from oceanc80

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmshort @camilamacedo86