Skip to content

Avoid the stuttering; Group tests by methods #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2020
Merged

Avoid the stuttering; Group tests by methods #13

merged 2 commits into from
Jul 26, 2020

Conversation

jmrodri
Copy link
Member

@jmrodri jmrodri commented Jul 26, 2020

Grouped the tests by method to avoid the stuttering of EnqueueRequestForAnnotation in the tests output.

EnqueueRequestForAnnotation EnqueueRequestForAnnotation                                                                
  should enqueue a Request with the annotations of the object in case of CreateEvent                                   
  /home/devel/jesusr/dev/operator-lib/handler/handler_test.go:68                                                       
•                                                                                                                      
------------------------------                                                                                         
EnqueueRequestForAnnotation EnqueueRequestForAnnotation                                                                
  should enqueue a Request with the annotations of the object in case of DeleteEvent                                   
  /home/devel/jesusr/dev/operator-lib/handler/handler_test.go:87                                                       
•
------------------------------

With this change the output would look more like this.

EnqueueRequestForAnnotation Create                                                                                                                                                                                                            
  should enqueue a Request with the annotations of the object in case of CreateEvent                                                                                                                                                          
  /home/devel/jesusr/dev/operator-lib/handler/enqueue_annotation_test.go:65                                                                                                                                                                   
•                                                                                                                                                                                                                                             
------------------------------
EnqueueRequestForAnnotation Create 
  should enqueue a Request to the owner resource when the annotations are applied in child object in the Create Event
  /home/devel/jesusr/dev/operator-lib/handler/enqueue_annotation_test.go:83
•
...
------------------------------                                                                                         
EnqueueRequestForAnnotation Delete                                                                                     
  should enqueue a Request with the annotations of the object in case of DeleteEvent
  /home/devel/jesusr/dev/operator-lib/handler/enqueue_annotation_test.go:232
•

@jmrodri jmrodri requested review from varshaprasad96, joelanford and rashmigottipati and removed request for joelanford and rashmigottipati July 26, 2020 01:42
@coveralls
Copy link

Pull Request Test Coverage Report for Build 182758278

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.244%
Totals Coverage Status
Change from base Build 181934631: 0.0%
Covered Lines: 275
Relevant Lines: 386
💛 - Coveralls

@varshaprasad96
Copy link
Member

Never realized this! I used to always overlook the messages and directly search for the line of error!
Thanks @jmrodri . Will follow this hereon :)

varshaprasad96
varshaprasad96 approved these changes Jul 26, 2020
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2020
camilamacedo86
camilamacedo86 approved these changes Jul 26, 2020
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jmrodri jmrodri merged commit 31bfca0 into operator-framework:main Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees

@camilamacedo86 camilamacedo86

@varshaprasad96 varshaprasad96

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmrodri @coveralls @varshaprasad96 @camilamacedo86 @openshift-ci-robot